From 6cd475a5d04844cd3a211f98e706412eb5dac7d6 Mon Sep 17 00:00:00 2001 From: Alexis Date: Mon, 13 Jun 2022 06:56:05 -0500 Subject: [PATCH 1/2] fix: ajuste respuesta de error --- controllers/nodo_cuenta_contable.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/controllers/nodo_cuenta_contable.go b/controllers/nodo_cuenta_contable.go index 2474428..4d9dbb6 100644 --- a/controllers/nodo_cuenta_contable.go +++ b/controllers/nodo_cuenta_contable.go @@ -2,6 +2,7 @@ package controllers import ( "encoding/json" + "net/http" "go.mongodb.org/mongo-driver/bson" "go.mongodb.org/mongo-driver/bson/primitive" @@ -288,8 +289,11 @@ func (c *NodoCuentaContableController) DeleteNode() { err := c.nodeCCManager.DeleteNodeByUUID(ID) if err == nil { message = "node-deleted" + c.Data["json"] = c.commonHelper.DefaultResponse(200, err, message) + } else { + c.Ctx.Output.SetStatus(http.StatusInternalServerError) + message = "node-deleted failed" + c.Data["json"] = c.commonHelper.DefaultResponse(500, err, message) } - - c.Data["json"] = c.commonHelper.DefaultResponse(200, err, message) c.ServeJSON() } From 86288aa4739868a9f215ab0a180ebc5c9b565804 Mon Sep 17 00:00:00 2001 From: Alexis Salcedo Date: Tue, 14 Jun 2022 05:43:17 -0500 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Alex Bustos --- controllers/nodo_cuenta_contable.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/nodo_cuenta_contable.go b/controllers/nodo_cuenta_contable.go index 4d9dbb6..639dd03 100644 --- a/controllers/nodo_cuenta_contable.go +++ b/controllers/nodo_cuenta_contable.go @@ -289,11 +289,11 @@ func (c *NodoCuentaContableController) DeleteNode() { err := c.nodeCCManager.DeleteNodeByUUID(ID) if err == nil { message = "node-deleted" - c.Data["json"] = c.commonHelper.DefaultResponse(200, err, message) + c.Data["json"] = c.commonHelper.DefaultResponse(http.StatusOK, err, message) } else { c.Ctx.Output.SetStatus(http.StatusInternalServerError) message = "node-deleted failed" - c.Data["json"] = c.commonHelper.DefaultResponse(500, err, message) + c.Data["json"] = c.commonHelper.DefaultResponse(http.StatusInternalServerError, err, message) } c.ServeJSON() }