Cleanup _main.ts generation and fix error boundary bugs #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For router generation, originally I put all that logic in _main.ts. This would cause it to get very messy and hard to follow what the actual structure is from looking at it. I moved all the logic of creating the Router objects into a function named generateRouter. This makes the file a lot easier to read. Below is the _main.ts for the example in this repository.
There was also bug in how error boundaries were automatically added to routers that resulted in the error boundary being wrong. With the logic more clearly written out in generateRouter, I was able to identify and resolve the issue.
I've also improved the readme to make it more clear how to add error boundaries to your routes.