Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Migrate for MySQL #1

Open
KyleJune opened this issue Nov 15, 2021 · 1 comment
Open

Implement Migrate for MySQL #1

KyleJune opened this issue Nov 15, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@KyleJune
Copy link
Member

I wrote this module with the intent for it to later be extended for other databases besides Postgres. The CLI and basic script should work with any Migrate object. If any additional code from PostgresMigrate can be moved to Migrate for re-use in MySQLMigrate, move it while working on it. We may want to move some of the code related to locking to the base class.

@KyleJune
Copy link
Member Author

I don't personally have a need for MySQL migration support so I'm not sure when I would get around to implementing this. If there is a lot of demand for it, I can do that. If anyone wants to take this task on I would be open to merging as long as there is good test coverage. To add it, you would need to update docker to have a mysql service. The quickest way to implement MySQLMigrate would be to copy postgres.ts and postgres_test.ts then adapt those copies to use mysql.

@KyleJune KyleJune added enhancement New feature or request help wanted Extra attention is needed labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant