Merge pull request #3359 from udecode/fix/trim-regex

Replace potentially inefficient RegExp with `String.trim()`
udecode · Jul 13, 2024 · e6ec43b · e6ec43b
2 parents a6691d7 + 92b0a3a
commit e6ec43b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/.changeset/stale-pandas-shake.md b/.changeset/stale-pandas-shake.md
@@ -0,0 +1,5 @@
+---
+"@udecode/plate-serializer-md": patch
+---
+
+Replace potentially inefficient RegExp with String.trim()
diff --git a/packages/serializer-md/src/serializer/serializeMdNodes.ts b/packages/serializer-md/src/serializer/serializeMdNodes.ts
@@ -11,8 +11,6 @@ import {
   serializeMdNode,
 } from './serializeMdNode';
 
-const trimNewlines = (str?: string) => str?.replace(/^\s+|\s+$/g, '') ?? '';
-
 /** Convert Slate nodes to Markdown. */
 export const serializeMdNodes = (
   nodes: TDescendant[],
@@ -51,15 +49,14 @@ export const serializeMdNodes = (
     return '';
   }
 
-  return trimNewlines(
-    nodes
-      ?.map((v) =>
-        serializeMdNode(v, {
-          ...options,
-          customNodes: options.customNodes as any,
-          nodes: optionsNodes,
-        })
-      )
-      .join('')
-  );
+  return nodes
+    ?.map((v) =>
+      serializeMdNode(v, {
+        ...options,
+        customNodes: options.customNodes as any,
+        nodes: optionsNodes,
+      })
+    )
+    .join('')
+    .trim();
 };