Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to fit modern rules. #2109

Open
FrenjaminBanklin opened this issue Aug 4, 2023 · 0 comments
Open

Update styles to fit modern rules. #2109

FrenjaminBanklin opened this issue Aug 4, 2023 · 0 comments
Labels
chore Maintain a clean and strong character. code quality css linting

Comments

@FrenjaminBanklin
Copy link
Contributor

See #2104.

Relies on #2108.

The update to Stylelint version 15 introduced a whole slew of new expectations that the existing code does not meet without significant configuration changes. Rather than overhaul (probably) every .scss file in the entire project, I opted instead to make any necessary package changes and simply override any rules that the existing code no longer passes.

Ideally rather than ignoring numerous Stylelint rules, we should update our code to validate against them where reasonably possible. This would likely mean removing most if not all of the new rule configuration changes (minus the class/id/keyframe naming rules, probably) and continuously linting the code to find rule violations, then fixing those violations and re-linting ad nauseum until everything has been modernized.

This would obviously also require checking that nothing changes in appearance following whatever changes are made.

@FrenjaminBanklin FrenjaminBanklin added css linting chore Maintain a clean and strong character. code quality labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintain a clean and strong character. code quality css linting
Projects
None yet
Development

No branches or pull requests

1 participant