Skip to content

Commit e85dc6e

Browse files
committed
Tweaked accessibility of filter options in catalog
1 parent d2e1c4e commit e85dc6e

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

src/components/catalog.jsx

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,9 @@ const Catalog = ({widgets = [], isLoading = true}) => {
155155
const filterOptionClickHandler = () => toggleFilter(filter)
156156
return <button key={index}
157157
className={'feature-button' + (isEnabled ? ' selected' : '')}
158+
aria-label={`Filter by ${filter}. ${isEnabled ? 'Selected.' : ''}`}
158159
aria-hidden={!state.showingFilters}
160+
disabled={!state.showingFilters}
159161
onClick={ filterOptionClickHandler }>
160162
{filter}
161163
</button>
@@ -167,7 +169,9 @@ const Catalog = ({widgets = [], isLoading = true}) => {
167169
const filterOptionClickHandler = () => toggleFilter(filter)
168170
return <button key={index}
169171
className={'feature-button' + (isEnabled ? ' selected' : '')}
170-
aria-hidden={!state.showingFilters}
172+
aria-label={`Filter by ${filter}. ${isEnabled ? 'Selected.' : ''}`}
173+
aria-hidden={!state.showingAccessibility}
174+
disabled={!state.showingAccessibility}
171175
onClick={ filterOptionClickHandler }>
172176
{ filter == 'Keyboard Accessible' ? <KeyboardIcon color='#000' /> : '' }
173177
{ filter == 'Screen Reader Accessible' ? <ScreenReaderIcon color='#000' /> : '' }
@@ -255,10 +259,12 @@ const Catalog = ({widgets = [], isLoading = true}) => {
255259
<span className='label'>Filter by:</span>
256260
<button
257261
className={`filter-toggle desktop-only ${state.showingFilters ? 'close-mode' : ''}`}
262+
aria-label={state.showingFilters ? 'Feature filters drawer open' : 'Filter catalog by features'}
258263
onClick={ filterLinkClickHandler }>
259264
Feature</button>
260265
<button
261266
className={`filter-toggle desktop-only ${state.showingAccessibility ? 'close-mode' : ''}`}
267+
aria-label={state.showingAccessibility ? 'Accessibility filters drawer open' : 'Filter catalog by accessibility'}
262268
onClick={ accessibilityLinkClickHandler }>
263269
Accessibility</button>
264270
<div className={'search' + (state.searchText === '' ? '' : ' not-empty')}>
@@ -291,14 +297,14 @@ const Catalog = ({widgets = [], isLoading = true}) => {
291297
</div>
292298
{ mobileFilterRender }
293299
<div id='filters-container'
294-
className={`ready ${state.showingFilters ? 'open' : 'closed'}`}>
295-
<div className='filter-labels-container'>
300+
className={`ready ${state.showingFilters ? 'open' : 'closed'}`} aria-hidden={!state.showingFilters}>
301+
<div className='filter-labels-container' disabled={!state.showingFilters}>
296302
{ filterOptionsRender }
297303
</div>
298304
</div>
299305
<div id='filters-container'
300-
className={`ready ${state.showingAccessibility ? 'open' : 'closed'}`}>
301-
<div className='filter-labels-container accessibility'>
306+
className={`ready ${state.showingAccessibility ? 'open' : 'closed'}`} aria-hidden={!state.showingAccessibility}>
307+
<div className='filter-labels-container accessibility' disabled={!state.showingAccessibility}>
302308
{ accessibilityOptionsRender }
303309
</div>
304310
</div>

src/components/catalog.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,10 @@
328328
text-decoration: none;
329329
}
330330

331+
&:focus {
332+
background-color: #e2f3ff;
333+
}
334+
331335
.header {
332336
float: left;
333337
// margin-top: -4px;

0 commit comments

Comments
 (0)