pam/integration-tests/native: Check that the user 'r' is accepted #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage ? 84.73%
=======================================
Files ? 79
Lines ? 6957
Branches ? 75
=======================================
Hits ? 5895
Misses ? 742
Partials ? 320 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Sep 24, 2024
This is something that was manually tested, but since 'r' is a special string in the native model, let's add an explicit check, ensuring that a such user can work properly. And no, we won't support a 'r' secret, even though we could just wait for a broker refusal before using it as a "go back" command.
3v1n0
force-pushed
the
pam-cancel-key-user-tests
branch
from
2b78755
to
02d20f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that was already manually tested, but since 'r' is a special string in the native model, let's add an explicit check, ensuring that a such user can work properly.
And no, we won't support a 'r' secret, even though we could just wait for a broker refusal before using it as a "go back" command, but at the date there's not a real requirement for that to increase the model complexity.