fix(pam/nativemodel): Do not report the authentication denied PAM error twice #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case that the authentication failed, the authentication model sends a pamError that includes the error message and that our pam module will eventually write. So, there's no need to handle the error again in the native module or we'd duplicate such error string
3v1n0
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 84.78% 84.74% -0.04%
==========================================
Files 79 79
Lines 6955 6957 +2
Branches 75 75
==========================================
- Hits 5897 5896 -1
- Misses 739 741 +2
- Partials 319 320 +1 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that the authentication failed, the authentication model sends a pamError that includes the error message and that our pam module will eventually write.
So, there's no need to handle the error again in the native module or we'd duplicate such error string
UDENG-4763