Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: QR code does not render in Microsoft Terminal (Windows 11) #497

Closed
3 of 4 tasks
heitbaum opened this issue Aug 26, 2024 · 6 comments · Fixed by #545
Closed
3 of 4 tasks

Issue: QR code does not render in Microsoft Terminal (Windows 11) #497

heitbaum opened this issue Aug 26, 2024 · 6 comments · Fixed by #545
Assignees
Labels
bug Something isn't working high High importance issue

Comments

@heitbaum
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and found none that matched mine

Describe the issue

The QR code displays as a series of ### numbers (not the QR code) this is using cmd, powershell. Works fine in putty.

Where does the issue happens

  • I can reproduce the issue in the graphical display manager
  • I can reproduce the issue on a terminal with "login"

Steps to reproduce it

  1. Open up a terminal session on windows 11
  2. ssh firstname.last@msentra.domian.com@ubuntubox
  3. Choose 2
  4. QR code is NOT displayed

System information and logs

Environment

  • broker version: please run snap info authd-msentraid 0.1 (33)
  • authd version: please run /usr/libexec/authd version 0.3.3
  • gnome shell version: please run apt policy gnome-shell
  • Distribution: (NAME in /etc/os-release) Ubuntu
  • Distribution version: (VERSION_ID on /etc/os-release): 24.04

Log files

Please redact/remove sensitive information:

Authd entries:

journalctl -u authd.service

MS Entra ID broker entries:

journalctl -u snap.authd-msentraid.authd-msentraid.service

Application settings

Please redact/remove sensitive information:

Broker configuration:

cat /var/snap/authd-msentraid/current/broker.conf

Broker authd configuration:

cat /etc/authd/brokers.d/msentraid.conf

Relevant information

No response

Double check your logs

  • I have redacted any sensitive information from the logs
@heitbaum heitbaum added the bug Something isn't working label Aug 26, 2024
@3v1n0
Copy link
Collaborator

3v1n0 commented Aug 26, 2024

This is using WSL or what ssh client?

The issue is handled upstream by openssh/openssh-portable#452 and we're carrying the patches for ubuntu 24.04 and prepared a backport for 22.04 and 20.04.

For the others, we won't probably show the qr code at all, but we need to handle the case in the server, so it will take a while too.

@ubuntu ubuntu deleted a comment Aug 26, 2024
@ubuntu ubuntu deleted a comment Aug 26, 2024
@ubuntu ubuntu deleted a comment Aug 26, 2024
@ubuntu ubuntu deleted a comment Aug 26, 2024
@heitbaum
Copy link
Author

This is using WSL or what ssh client?

The issue is handled upstream by openssh/openssh-portable#452 and we're carrying the patches for ubuntu 24.04 and prepared a backport for 22.04 and 20.04.

For the others, we won't probably show the qr code at all, but we need to handle the case in the server, so it will take a while too.

this is the native ssh client in Windows11

C:\Users\MyUser>ssh -V
OpenSSH_for_Windows_8.6p1, LibreSSL 3.4.3

@jibel
Copy link
Collaborator

jibel commented Aug 27, 2024

I confirm the issue with the SSH client of Windows 11
image

For the moment, I'd recommend to use an alternative client that supports UTF-8 such as Putty
image

@heitbaum
Copy link
Author

same as #500

@bill-taut
Copy link

It would be great if the login code were provided as text so it could be simply typed into the devicelogin URL without having to scan the QR code. This would also be a workaround for the UTF-8 not rendering correctly (which is a problem also on MacOS.

@jibel
Copy link
Collaborator

jibel commented Sep 6, 2024

We do not have a good way to handle this at the moment because the client is not exposed to PAM by the server and many clients are affected. So we're going to not display QR code for SSH.

3v1n0 added a commit to 3v1n0/authd that referenced this issue Sep 19, 2024
And add an integration test covering this case

Closes: ubuntu#497
3v1n0 added a commit to 3v1n0/authd that referenced this issue Sep 19, 2024
And add an integration test covering this case

Closes: ubuntu#497
@3v1n0 3v1n0 closed this as completed in f3dfb49 Sep 20, 2024
3v1n0 added a commit that referenced this issue Sep 20, 2024
Do not renderer qrcode in SSH at all, the only clients supporting it are
putty and `ssh` provided by ubuntu (>= 24.04), and it's not possible
(yet) to detect this from PAM level, so let's just ignore it for now.

And add an integration test covering this case.

Closes: #497 

UDENG-4279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high High importance issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@3v1n0 @jibel @heitbaum @bill-taut and others