Draft: feat(extra): add tuxedo-drivers (#129) #329
Conversation
dosubot
bot
added
size:S
|
Hi @gladion136. Thank you for the PR and for your efforts to get this ready for inclusion in Universal Blue. I recognize it's a bit tricky to build akmods locally since the recent changes to include kernel-cache as part of the akmods process. I'm working on a small cleanup of akmods right now, after which I'll get back to you with some thoughts on how to get a local build going. Longer term, I want to clean this up even more so it's much simpler to run local builds, but that's a different topic. |
|
Does someone have time to review this again? Would love to have better support for hardware manufacturers that support linux ootb. I would ship this in bluefin! |
|
I was looking at this last night. Where this got stuck is our current way of caching kernels makes it awkward to only do local akmod build testing. I think the minimal solution is to move the kernel cache logic into a Justfile and probably a build akmods recipe as well. At that point the original contributor can easily test the submission. |
|
Agreed. With the current setup it makes it difficult for local builds and for those that do not have write permissions |
|
Oh this looks great, I can also try this on my IBP 14 Gen8 once it's ready for that. |
|
gladion136
force-pushed
the
feat/extra-add-tuxedo-driver
branch
2 times, most recently
from
f931cc3 to
f96c0da
Compare
|
I finally reworked the local building for akmods. Once that lands you will be able to locally build through kmod. #356 The kmod will be signed with our test key. You can either disable secureboot or enroll the test key to test out the kmod. To then test the kmod, you will need to either locally layer the rpm with rpm-ostree. |
gladion136
force-pushed
the
feat/extra-add-tuxedo-driver
branch
2 times, most recently
from
d246219 to
4487a6f
Compare
m2Giles
left a comment
m2Giles
left a comment
There was a problem hiding this comment.
This looks good. You can put this in the block for common.
Are you now able to test building this?
|
|
||
| ARCH="$(rpm -E '%_arch')" | ||
| KERNEL="$(rpm -q "${KERNEL_NAME}" --queryformat '%{VERSION}-%{RELEASE}.%{ARCH}')" | ||
| RELEASE="$(rpm -E '%fedora')" |
There was a problem hiding this comment.
Are you only building for Fedora?
There was a problem hiding this comment.
Yes, should I build for others too? I tried to keep it similar to the kvmfr script (https://copr.fedorainfracloud.org/coprs/hikariknight/looking-glass-kvmfr/).
| KERNEL="$(rpm -q "${KERNEL_NAME}" --queryformat '%{VERSION}-%{RELEASE}.%{ARCH}')" | ||
| RELEASE="$(rpm -E '%fedora')" | ||
|
|
||
| if [[ "${RELEASE}" -ge 41 ]]; then |
There was a problem hiding this comment.
Rawhide is F43. We also currently don't publish a rawhide akmods image.
There was a problem hiding this comment.
Thanks, I removed the statement 👍 I also updated the copr to build for 43 and rawhide too.
gladion136
force-pushed
the
feat/extra-add-tuxedo-driver
branch
2 times, most recently
from
abe3cca to
9328248
Compare
Signed-off-by: Etienne Schmidt <[email protected]>
gladion136
force-pushed
the
feat/extra-add-tuxedo-driver
branch
from
9328248 to
5ebc9bd
Compare
6 participants
Hello, this PR adds tuxedo-drivers to akmods. It corresponding to this issue. The whole thing is currently WIP, so this PR is first on draft.
Can someone help me out a bit?
Is it possible to build akmods locally to debug the errors? Since the code restructuring I have not found a way..
And is "extra" the right area for the tuxedo-driver?
Source Repository: https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers
Spec Source Repository: https://github.com/gladion136/tuxedo-drivers-kmod
Copr: https://copr.fedorainfracloud.org/coprs/gladion136/tuxedo-drivers-kmod/