Skip to content

Commit 1e0c5ff

Browse files
committed
update docker compose setup and docs
1 parent ae0ba09 commit 1e0c5ff

File tree

5 files changed

+32
-10
lines changed

5 files changed

+32
-10
lines changed

DEPLOYMENT.md

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,24 @@
7777
make -C docs-sphinx open_local_docs
7878
```
7979

80-
14. Create a git commit:
80+
14. Authenticate with GitHub Personal Access Token (PAT):
81+
```shell
82+
jq -r .github_personal_access_token.value auth/github/private.json | docker login ghcr.io -u uberfastman --password-stdin
83+
```
84+
85+
15. Deploy the newly-built Docker image with respective major, minor, and patch version numbers to the GitHub Container Registry:
86+
```shell
87+
docker push ghcr.io/uberfastman/yfpy:X.X.X
88+
```
89+
90+
16. Create a git commit:
8191

8292
```shell
8393
git add .
8494
git commit -m 'commit message'
8595
```
8696

87-
15. Update the git tag with the new version:
97+
17. Update the git tag with the new version:
8898

8999
`git tag -a [tag_name/version] -m [message]`
90100

@@ -93,32 +103,32 @@
93103
git push origin --tags
94104
```
95105

96-
16. Install `twine` (if not already installed):
106+
18. Install `twine` (if not already installed):
97107

98108
```shell
99109
pip install twine
100110
```
101111

102-
17. *(Optional)* Test deployment by building the PyPI packages, recreating the documentation, and deploying to Test PyPI:
112+
19. *(Optional)* Test deployment by building the PyPI packages, recreating the documentation, and deploying to Test PyPI:
103113

104114
```shell
105115
make -C docs-sphinx test_deploy
106116
```
107117

108-
18. Deploy YFPY by building the PyPI packages, recreating the Sphinx documentation, and deploying to PyPI:
118+
20. Deploy YFPY by building the PyPI packages, recreating the Sphinx documentation, and deploying to PyPI:
109119

110120
```shell
111121
make -C docs-sphinx deploy
112122
```
113123

114-
19. Create a second git commit with updated version number and documentation:
124+
21. Create a second git commit with updated version number and documentation:
115125

116126
```shell
117127
git add .
118128
git commit -m 'update version number and docs'
119129
```
120130

121-
20. Update YFPY GitHub repository:
131+
22. Update YFPY GitHub repository:
122132

123133
```shell
124134
git push

MANIFEST.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ include auth/.env.template
1414

1515
# Include YFPY Docker resources
1616
include compose.yaml
17+
include compose.dev.yaml
1718

1819
# Include quickstart resources
1920
include quickstart/quickstart.py

README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,16 @@ YFPY can be used within Docker for a more seamless, platform-agnostic experience
139139
docker exec -i yfpy-package-1 bash -c "python quickstart/quickstart.py"
140140
```
141141

142-
***NOTE***: *If you wish to actively make changes to or develop against YFPY within the Docker container, uncomment the `- .:/opt/yfpy` volume mount in [`compose.yaml`](https://github.com/uberfastman/yfpy/blob/main/compose.yaml) so that any code changes you make in YFPY are reflected inside the running container.*
142+
##### Docker Development (optional)
143+
144+
* Run the Docker container for local development (mount all local code into container):
145+
```shell
146+
docker compose -f compose.yaml -f compose.dev.yaml up
147+
```
148+
149+
##### Docker Image Deployment
150+
151+
See [DEPLOYMENT.md](https://github.com/uberfastman/yfpy/blob/main/DEPLOYMENT.md) for Docker image deployment.
143152

144153
---
145154

compose.dev.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
services:
2+
package:
3+
volumes:
4+
- .:/opt/yfpy

compose.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,3 @@ services:
1717
- 5001:5000
1818
volumes:
1919
- /etc/localtime:/etc/localtime
20-
# UNCOMMENT LOCAL CODE REPOSITORY MOUNT BELOW FOR LOCAL CHANGES TO BE REFLECTED WITHIN THE RUNNING DOCKER CONTAINER
21-
#- .:/opt/yfpy

0 commit comments

Comments
 (0)