Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.uber.tchannel.api.SubChannel not thread safe, not documented #163

Open
alshopov opened this issue Mar 14, 2017 · 0 comments
Open

com.uber.tchannel.api.SubChannel not thread safe, not documented #163

alshopov opened this issue Mar 14, 2017 · 0 comments
Assignees

Comments

@alshopov
Copy link
Contributor

Class SubChannel keeps handlers in
private final Map<String, RequestHandler> requestHandlers = new HashMap<>();

most often calls to
public SubChannel register(String endpoint, RequestHandler requestHandler)
make structural changes to the HashMap which means that the SubChannel class is not thread safe - register(String endpoint, RequestHandler) must be called from a single thread (or change the underlying map implementation)

@alshopov alshopov self-assigned this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant