Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read should return partial data when available #466

Open
prashantv opened this issue Jul 29, 2016 · 0 comments
Open

Read should return partial data when available #466

prashantv opened this issue Jul 29, 2016 · 0 comments

Comments

@prashantv
Copy link
Contributor

Right now, Read will try to fill the whole buffer, even if it means blocking and waiting for another packet.

See PR for more information:
And specific commit to fix this: #173
fb2ea23

I have started a separate branch with a slightly different fix, but there's a few items to do:

  • add unit tests to catch this issue and ensure it's fixed
  • Consider simplifying Read even more

This doesn't affect any of our users currently as streaming is not widely used, and the few streaming users we have use Thrift streaming, which will pass in the exact buffer size (e.g., the caller knows exactly how much data to read, and wants full reads).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant