Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Tuning #1346

Open
Xiot opened this issue Jun 4, 2020 · 1 comment
Open

Performance Tuning #1346

Xiot opened this issue Jun 4, 2020 · 1 comment

Comments

@Xiot
Copy link
Contributor

Xiot commented Jun 4, 2020

Before we get too heavy into re-designing and tuning these components, we should have a way to measure that we are actually making things better, at least from a performance point of view.

React has recently introduced the Profiler api [link] as a way to get some insight into where our components are spending time, and when they re-render.

Blog post introducing the api.
I also found the storybook-addon-performance which adds a performance tab to story book.

We can use this thread to discuss how we want to both measure and track our performance gains.
Do we want to just do performance testing in an adhoc manor, (ie, manually test before and after a set of changes), or do we want to try and bake performance tests into the travis build?

@Xiot
Copy link
Contributor Author

Xiot commented Jun 4, 2020

There is definitely some low hanging fruit #1314 where we can easily see the performance benefit be memoizing values before passing them to children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant