Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weighted_sampling_reader #770

Open
weidezhang opened this issue Aug 19, 2022 · 3 comments
Open

weighted_sampling_reader #770

weidezhang opened this issue Aug 19, 2022 · 3 comments

Comments

@weidezhang
Copy link

one question I want to ask is why the weighted sampling reader requires all reader have the exact same schema ? Can we modify it so that each reader have different schemas ?

@weidezhang
Copy link
Author

say i want to have a reader A contains schema (a,b,c) while another reader B schema contains (a,b,c,d). Can they both be sampled together ? The extra field in B will be used on extra loss function defined in the network.

@selitvin
Copy link
Collaborator

It was design that way to support old TF reading style : the schema must have been known in advance to hook the reader into TF graph. This might not be necessary when not reading from TF. If you'd like to propose a PR, I would be happy to take a look.

@weidezhang
Copy link
Author

thx for the confirmation. we will propose a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants