Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the latest scikit-learn #682

Closed
jeongyoonlee opened this issue Sep 22, 2023 · 2 comments
Closed

Support the latest scikit-learn #682

jeongyoonlee opened this issue Sep 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jeongyoonlee
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Current causal tree implementation depends on scikit-learn<=1.0.2, and it raises Cython errors with the latest scikit-learn due to the change introduced in scikit-learn/scikit-learn#22328.

Describe the solution you'd like

Updating the caudal tree code with the changes in scikit-learn/scikit-learn#22328.

Describe alternatives you've considered

Adding scikit-learn/scikit-learn/tree as a subtree (ref). This may help better sync the causalml and scikit-learn's tree implementations while allowing the usage of the latest scikit-learn.

Additional context
N/A

@jeongyoonlee jeongyoonlee added the enhancement New feature or request label Sep 22, 2023
@ras44
Copy link
Collaborator

ras44 commented Sep 24, 2023

see also discussion in #619

@jeongyoonlee
Copy link
Collaborator Author

Resolved with #686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants