Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPS Wrapper Additions #30

Merged
merged 6 commits into from
Oct 27, 2024
Merged

MPS Wrapper Additions #30

merged 6 commits into from
Oct 27, 2024

Conversation

jimgeng
Copy link
Collaborator

@jimgeng jimgeng commented Oct 5, 2024

Description

  • Changed previous wrapper endpoints to without drone/ prefix for calls to actual MPS endpoints, it seems like they are not supposed to be there.
  • Updated rtl endpoint to include GET method.
  • Added missing MPS endpoints:
/insert : POST
/clear : GET
/diversion : POST
/flightmode : POST

Resolves # (issue)

Type of change

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

  • Test each GCOM endpoint and see if it makes the correct request to MPS.
  • Test with the SITL (is this necessary?)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@i25052i
Copy link

i25052i commented Oct 5, 2024

Just letting you know that there are some changes in the pipeline for some MPS endpoints in this PR. We're mainly deprecating the VTOL endpoints since neither of our aircraft this year are capable of VTOL-plane transition.

@jimgeng jimgeng linked an issue Oct 19, 2024 that may be closed by this pull request
@21chanas3 21chanas3 merged commit 14f0e33 into main Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MP Wrapper
3 participants