Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor /prepend and /append #75

Closed
i25052i opened this issue May 12, 2024 · 1 comment · May be fixed by #88
Closed

Refactor /prepend and /append #75

i25052i opened this issue May 12, 2024 · 1 comment · May be fixed by #88
Labels
Priority: Medium Status: Available Issue can be picked up Type: Bug Something isn't working

Comments

@i25052i
Copy link
Contributor

i25052i commented May 12, 2024

Describe the bug

  • Currently the mechanism the /append waypoint uses to add a new Waypoint to the queue is unreliable. Change it to reconstruct the mission entirely like with a new mission.
    • See the PUSH section in client.py. Also, rename PUSH to something more sensible
  • Currently the /prepend endpoint is very slow, because it 1. obtains the queue from MissionPlanner, 2. constructs the new queue, and 3. sends it back to MissionPlanner. If this logic was handled entirely within client.py, the endpoint, and the time it takes for the new queue to take effect, would be faster.
    • The mechanism for adding the prepended mission should be the same as above.

Reproduction steps

Call either endpoint

Expected behaviour

No response

Additional context

No response

@i25052i i25052i added Status: Available Issue can be picked up Type: Bug Something isn't working Priority: Medium labels May 12, 2024
@i25052i
Copy link
Contributor Author

i25052i commented May 16, 2024

Also, update them to support waypoint commands like for POST /queue in #74

@i25052i i25052i linked a pull request Jun 6, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Status: Available Issue can be picked up Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants