Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for individual components #93

Open
chuck-sys opened this issue Feb 1, 2020 · 1 comment · May be fixed by #95
Open

Add unit tests for individual components #93

chuck-sys opened this issue Feb 1, 2020 · 1 comment · May be fixed by #95
Assignees
@chuck-sys
Labels
dev type type type enhancement New feature or request refactor Places we can tidy up research Study up before implementing something

Comments

@chuck-sys
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have tests for non-React components, just not the React ones.

Describe the solution you'd like
We want to have tests for React components, unit tests.

Additional context
There is tight coupling between these components. By writing tests, we can know what things we can separate and what things we need to work on separating.
@chuck-sys chuck-sys added dev type type type enhancement New feature or request refactor Places we can tidy up research Study up before implementing something labels Feb 1, 2020
@chuck-sys chuck-sys added this to the Term 2 milestone Feb 1, 2020
@chuck-sys chuck-sys self-assigned this Feb 1, 2020
@chuck-sys
Copy link
Contributor Author

Also, WHY DO OUR TESTS TAKE LIKE 16 SECONDS TO RUN WHAT ARE WE DOING IN THERE???

@chuck-sys chuck-sys linked a pull request Feb 8, 2020 that will close this issue
Open
chuck-sys added a commit that referenced this issue Feb 29, 2020
@chuck-sys
Merge branch 'master' into cheukyin699/#93-component-unittests
eae5b60
@chuck-sys chuck-sys removed this from the Term 2 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuck-sys chuck-sys

Labels
dev type type type enhancement New feature or request refactor Places we can tidy up research Study up before implementing something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add unit tests to components ubclaunchpad/ubcsim2
1 participant
@chuck-sys