Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot multi-select playlist items if the current page is scrolled off #648

Open
fawaf opened this issue May 25, 2017 · 8 comments
Open
Labels
Milestone

Comments

@fawaf
Copy link
Member

fawaf commented May 25, 2017

it reverts to allowing a single item to be selected (and then you can only multi-select on the same page)

@fawaf
Copy link
Member Author

fawaf commented May 25, 2017

actually, it might be that it is a bit buggy. it sometimes works and sometimes does not.

@goto-bus-stop
Copy link
Member

Yeah you're right, it is indeed a bit buggy, I'm not sure why. Thanks for opening an issue for it 🙇‍♀️

@goto-bus-stop
Copy link
Member

Ah, I think it happens when a new playlist page is autoloaded while you scroll. That replaces the playlist items array, which clears the selection.

@goto-bus-stop
Copy link
Member

Fixed in #684, thanks!

@fawaf fawaf reopened this Mar 20, 2018
@fawaf
Copy link
Member Author

fawaf commented Mar 20, 2018

seems like it still does it if i scroll more than a couple times.

@fawaf
Copy link
Member Author

fawaf commented Mar 20, 2018

i'm noticing that it happens semi-infrequently, but it still seems to occur.

@fawaf
Copy link
Member Author

fawaf commented Mar 20, 2018

i noticed that it seems to happen if i scroll and don't click within some number of time.

@goto-bus-stop
Copy link
Member

I just ran into this again and I think it happens primarily with the shift-click range selection, so if you select 1 thing and scroll for a while and shift-select another it doesn't remember the range.

@goto-bus-stop goto-bus-stop added this to the v2 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants