Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve byte array/buffer handling when reading from storage #120

Open
tzaeschke opened this issue Apr 27, 2020 · 0 comments
Open

Improve byte array/buffer handling when reading from storage #120

tzaeschke opened this issue Apr 27, 2020 · 0 comments
Labels
enhancement internal

Comments

@tzaeschke
Copy link
Owner

The handling of ByteBuffers while reading from disk is not optimal.

  • We copy the entire page from one ByteBuffer to another before reading
  • Copying the byte buffer requires a synchronized block because copying a ByteBuffer requires rewinding it (modifying it).

Both could be avoided by using a ByteBufferWrapper that wraps whichever ByteBuffer needs to be read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzaeschke