Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuples do not respect optional elements #34

Open
m-haug opened this issue Jun 24, 2024 · 1 comment · May be fixed by #41
Open

Tuples do not respect optional elements #34

m-haug opened this issue Jun 24, 2024 · 1 comment · May be fixed by #41
Labels
bug Something isn't working schema Issue or PR relating to valkyrie schema
Milestone
0.2.2

Comments

@m-haug
Copy link

m-haug commented Jun 24, 2024

I'm trying to parse a schema with an optional trailing content using tuple. However, when I use a schema like

tuple(string(), string(), content(optional: true))

valkyrie panics when trying to access the third element of the tuple if the trailing content is not specified.
@jamesrswift
Copy link
Member

Fixed in next version (see #31 )

@tingerrr tingerrr added bug Something isn't working schema Issue or PR relating to valkyrie schema labels Jun 28, 2024
@jamesrswift jamesrswift added this to the v0.2.2 milestone Jul 14, 2024
@jamesrswift jamesrswift linked a pull request Jul 24, 2024 that will close this issue
Open
@jamesrswift jamesrswift linked a pull request Jul 24, 2024 that will close this issue
Attempt to more properly count expected variables in tuple #41
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working schema Issue or PR relating to valkyrie schema
Projects
None yet
Milestone
0.2.2
Development

Successfully merging a pull request may close this issue.

Attempt to more properly count expected variables in tuple typst-community/valkyrie
3 participants
@jamesrswift @m-haug @tingerrr