fix: Wrong logic for render decorator

[shushanfx]

Description

I added a @Render() decorator for one of my routes， but other routes were also affected. I debuged into the code, and in KoaDriver, I found this:

    else if (action.renderedTemplate) {
      // if template is set then render it // TODO: not working in koa
      const renderOptions = result && result instanceof Object ? result : {};

      this.koa.use(async function (ctx: any, next: any) {
        await ctx.render(action.renderedTemplate, renderOptions);
      });
    }

This could result in the following two results:

1. Affect other routes which are not marked with @Render decorator.
2. Register a middleware for koa for every @Render request.

Solution

I suggest change this code to this.

       else if (action.renderedTemplate) {
            const renderOptions = result && result instanceof Object ? result : {};
            return Promise.resolve(
                    options.context.render(action.renderedTemplate, renderOptions)
                ).then(() => options.next())
        }

[Telokis]

Making the KoaDriver::handleSuccess function async and using

await options.context.render(action.renderedTemplate, renderOptions);

works as expected without shortcircuiting the following processing.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.