Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Ionic build with minifyjs option, the CircularRelationError will be emitted. #27

Open
JeongJun-Lee opened this issue Jul 28, 2018 · 1 comment

Comments

@JeongJun-Lee
Copy link

JeongJun-Lee commented Jul 28, 2018

When I try to build with --minifyjs, it also emits circular relations error like this. The minifyjs option includes the mangling by uglifyjs. I think the TypeORM is not safe about this mangling process. But the mangling process in Ionic is default. Ionic itself includes this mangling process in production build process with --prod option.

ERROR Error: Uncaught (in promise): CircularRelationsError: Circular relations detected: e -> t -> e. To resolve this issue you need to set nullable: false somewhere in this dependency structure.
CircularRelationsError: Circular relations detected: e -> t -> e. To resolve this issue you need to set nullable: false somewhere in this dependency structure.
at new t (vendor.js:1)
at e.validateDependencies (vendor.js:1)
at e.validateMany (vendor.js:1)
at e.buildMetadatas (vendor.js:1)
at e. (vendor.js:1)
at vendor.js:1
at Object.next (vendor.js:1)
at s (vendor.js:1)
at t.invoke (polyfills.js:3)
at Object.onInvoke (vendor.js:1)
at new t (vendor.js:1)
at e.validateDependencies (vendor.js:1)
at e.validateMany (vendor.js:1)
at e.buildMetadatas (vendor.js:1)
at e. (vendor.js:1)
at vendor.js:1
at Object.next (vendor.js:1)
at s (vendor.js:1)
at t.invoke (polyfills.js:3)
at Object.onInvoke (vendor.js:1)
at c (polyfills.js:3)
at polyfills.js:3
at polyfills.js:3
at t.invoke (polyfills.js:3)
at Object.onInvoke (vendor.js:1)
at t.invoke (polyfills.js:3)
at r.run (polyfills.js:3)
at polyfills.js:3
at t.invokeTask (polyfills.js:3)
at Object.onInvokeTask (vendor.js:1)

@JeongJun-Lee
Copy link
Author

By this mention, typeorm/typeorm#2597, if to prevent mangling as the limitation of TypeORM usage in Ionic is correct, please add this limitation to document. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant