Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats 2.12 upgrades? #53

Open
rossabaker opened this issue Jun 25, 2024 · 5 comments
Open

Cats 2.12 upgrades? #53

rossabaker opened this issue Jun 25, 2024 · 5 comments

Comments

@rossabaker
Copy link
Member

Was something done to stifle Cats 2.12.0 PRs? There are a lot of projects with broken Native PRs because they got 2.11.0 but were never offered 2.12.

Example: typelevel/cats-mtl#573

@djspiewak
Copy link
Member

I'm very confused as to what this means?

@rossabaker
Copy link
Member Author

The Cats version on that project is 2.11.0. It never received a pull request from Scala Steward for 2.12.0. That PR -- and many like it -- are failing because there's no Scala Native for that version of Cats. They could probably be made green by also upgrading to Cats 2.12.0.

The question here is, why didn't Steward notice there's a Cats 2.12.0?

@djspiewak
Copy link
Member

Ahhhh interesting question.

@armanbilge
Copy link
Member

armanbilge commented Jun 30, 2024

(edit: my hypothesis, I'm not an expert on steward implementation)

It's not offered Cats 2.12 because there is no Cats 2.12 for Scala Native 0.4, which that project is currently on.

Because Cats 2.12 and Scala Native 0.5 must go hand-in-hand, this situation must be resolved manually. Steward does not know that those updates must happen in the same PR.

@mzuehlke
Copy link

mzuehlke commented Jul 1, 2024

It's not offered Cats 2.12 because there is no Cats 2.12 for Scala Native 0.4, which that project is currently on.

Thats sound like a very likely explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants