Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Client exposes too many methods to create Options object #294

Closed
james-whiteside opened this issue May 18, 2023 · 1 comment
Closed

Client exposes too many methods to create Options object #294

james-whiteside opened this issue May 18, 2023 · 1 comment

Comments

@james-whiteside
Copy link

james-whiteside commented May 18, 2023

Description

Client Python currently exposes too many methods to create a TypeDBOptions object. It can be instantiated through any of the following:

TypeDBOptions().core()
TypeDBOptions().cluster()
TypeDBClusterOptions().core()
TypeDBClusterOptons().cluster()

This creates ambiguity in which methods to use, not to mention including nonsensical options.

Environment

  1. TypeDB client-python version: 2.17.0
  2. Python version: 3.9.16

Expected Output

Only two options should be exposed, probably among the following:

TypeDBOptions().core()
TypeDBOptions().cluster()

or

TypeDBOptions()
TypeDBClusterOptions()

or

TypeDBOptions().core()
TypeDBClusterOptions().cluster()

Actual Output

Client Python exposes the four options listed above.

@flyingsilverfin
Copy link
Member

Fixed in the refactor that occurred in #304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants