You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's nothing that prevents Grakn Core to load Maven packages declared in the artifacts.bzl coming from Grabl Tracing. This is not ideal since Grakn Core should only be able to depend on Maven dependencies explicitly declared in artifacts.bzl.
The text was updated successfully, but these errors were encountered:
lolski
pushed a commit
to lolski/dependencies
that referenced
this issue
Oct 7, 2022
…ft as well as a published release (typedb#269)
## What is the goal of this PR?
We have added a `draft` parameter to `deploy_github`. If it is set to `True`, the rule will create a release that is marked as draft. When set to `False`, the release will be immediately published.
This is an improvement of the existing behaviour, in which you can only create a draft release.
## What are the changes implemented in this PR?
- Implement the `draft` field
- Refactor the rule and `deploy.py` template
Right now, it is possible for packages inside Grakn Core to depend on libraries declared in
artifacts.bzl
of other repositories.For example, take the following example where Grakn Core also needs to load
artifacts.bzl
from Grabl Tracing:There's nothing that prevents Grakn Core to load Maven packages declared in the
artifacts.bzl
coming from Grabl Tracing. This is not ideal since Grakn Core should only be able to depend on Maven dependencies explicitly declared inartifacts.bzl
.The text was updated successfully, but these errors were encountered: