You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We found a Bazel rule @rules_foreign_cc [link] which allows for building make projects from inside a Bazel workspace. We should replace our builder script RocksDbBuilder.kt with this rule if possible
The text was updated successfully, but these errors were encountered:
I couldn't get it to work on the first try, but the Bazel WORKSPACE and BUILD files would roughly look like this, according to the @rules_foreign_cc's README:
## What is the goal of this PR?
Recently, a problem in`assemble_pip` was discovered:
```
File "/home/********/.cache/bazel/_bazel_********/a3bf690c4bacc2f8a31e33bc35f6090b/sandbox/linux-sandbox/191/execroot/graknlabs_client_python/bazel-out/host/bin/external/graknlabs_bazel_distribution/pip/assemble.runfiles/pypi__setuptools_45_0_0/pkg_resources/__init__.py", line 93, in <module>
raise RuntimeError("Python 3.5 or later is required")
RuntimeError: Python 3.5 or later is required
```
Given that we are still using Python 2 to build and test `client-python`, we need to downgrade `setuptools` to a supported version
## What are the changes implemented in this PR?
Depend on exact version of `setuptools` in `pip/requirements.txt`
We found a Bazel rule
@rules_foreign_cc
[link] which allows for buildingmake
projects from inside a Bazel workspace. We should replace our builder scriptRocksDbBuilder.kt
with this rule if possibleThe text was updated successfully, but these errors were encountered: