Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RoleType Concept tests #100

Open
alexjpwalker opened this issue Sep 1, 2020 · 2 comments
Open

Add RoleType Concept tests #100

alexjpwalker opened this issue Sep 1, 2020 · 2 comments

Comments

@alexjpwalker
Copy link
Member

alexjpwalker commented Sep 1, 2020

Problem to Solve

RoleType Concept methods were all broken in client-java and I didn't know about it, because we have no RoleType Concept tests.

Proposed Solution

Add RoleType Concept tests

@haikalpribadi
Copy link
Member

Please make sure that these new scenarios pass in Grakn Core 2.0 too before merging, @alexjpwalker.

@alexjpwalker
Copy link
Member Author

We still don't have this, but most RoleType methods are in fact tested anyway - either directly in a RelationType test, or indirectly by being called from other methods in RelationType, which are themselves tested. So I don't think this is urgent, and may in fact not be needed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants