Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate requiring the standard observer to be a parameter of the CIE spaces #6

Open
tylerreisinger opened this issue Dec 3, 2018 · 0 comments
Open

Evaluate requiring the standard observer to be a parameter of the CIE spaces #6

tylerreisinger opened this issue Dec 3, 2018 · 0 comments
Labels
correctness Changes that make it harder to incorrectly use the library or generate invalid results enhancement

Comments

@tylerreisinger
Copy link
Owner

It is incorrect to compare XYZ coordinates with different standard observers together. Evaluate if it would be worth extending Xyz<T> to Xyz<T, S> where S is a unit struct encoding the color matching functions used.
@tylerreisinger tylerreisinger added enhancement correctness Changes that make it harder to incorrectly use the library or generate invalid results labels Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correctness Changes that make it harder to incorrectly use the library or generate invalid results enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tylerreisinger