You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've put the asterisk next to "might" because that's just a suggestion for the spelling. Other options that come to mind:
.checkerboard() <-- Might mean some shaders clash with other modifiers?
.infernoEffect(.checkerboard(size: 50, replacement: .red)) <-- uses enum associated values, and means we have only one top-level View modifier rather than one for each shader.
Two tips:
You don't need to convert them all. In fact, it's better to convert a small number at a time then commit that change, to avoid clashes with other developers.
You're welcome to submit other API naming ideas – I'd rather have a discussion about it and reach a consensus than just dive in with the first option that comes to mind 🙂
Thank you!
The text was updated successfully, but these errors were encountered:
Hi @twostraws, Thank you for all the work on Inferno! I’m interested in contributing!
I wanted to check on the current status of this – have there been any decisions around the naming convention for the new extensions?
Looking at the code, thanks to the @daprice contribution 🙌, it seems like there’s already an extension for the variableBlur shader. I’m curious about your thoughts on the naming convention used there. Would you prefer something more uniform across the board? For example, I’d suggest including "Inferno" in all the ViewModifier names (e.g., infernoCheckerboardEffect, infernoVariableBlur, etc.), to avoid potential conflicts with existing or future SwiftUI modifiers.
The goal here is to make the shaders easily to apply by wrapping them in View extensions. So, rather than writing this:
Users might* instead write this:
I've put the asterisk next to "might" because that's just a suggestion for the spelling. Other options that come to mind:
Two tips:
Thank you!
The text was updated successfully, but these errors were encountered: