Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count based windows #40

Open
degloff opened this issue Jul 26, 2018 · 2 comments
Open

Count based windows #40

degloff opened this issue Jul 26, 2018 · 2 comments

Comments

@degloff
Copy link

degloff commented Jul 26, 2018

There is a trait for count based windows but it looks like it is not yet finished?

@icexelloss
Copy link
Member

Hi - Yes it's not implemented.

The issue is that it is hard to know how many previous partitions to look at in order to n rows. A better way to probably to implement a time-bounded count window, e.g., 10 rows with in past 3 days - which will give you either 10 rows or all the available rows within the past 3 days, whichever is smaller.

@degloff
Copy link
Author

degloff commented Jul 26, 2018

I see your point, that makes total sense and is not a big compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants