Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lombok #646

Closed
aSemy opened this issue Sep 19, 2021 · 2 comments · May be fixed by #647
Closed

Remove Lombok #646

aSemy opened this issue Sep 19, 2021 · 2 comments · May be fixed by #647
Labels
status: wontfix enhancement or fix that was rejected type: question question directed at the library

Comments

@aSemy
Copy link

aSemy commented Sep 19, 2021

Issue Summary

At the moment this project depends on Lombok

<groupId>org.projectlombok</groupId>

Lombok is mostly used for basic functionality, usually adding default toString() methods. These can be auto generated instead, and so a dependency on Lombok adds overhead to this project.

Because Lombok generates the code behind the scenes, it's not easily possible to tell if the code Lombok generates is even necessary.

Additionally because Lombok edits the code during compilation this means other tools that do post processing (documentation generators, optimisation and analysis tools, etc) are much more difficult, if not impossible, to use.

Please remove Lombok from the project.

@eshanholtz
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@eshanholtz eshanholtz added code-generation issue deals with generated code status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Sep 27, 2021
@childish-sambino
Copy link
Contributor

I disagree that Lombok is not beneficial. It reduces the amount of code needed to be maintained. Post-processing tools should work off the delomboked source.

@childish-sambino childish-sambino added status: wontfix enhancement or fix that was rejected and removed code-generation issue deals with generated code type: twilio enhancement feature request on Twilio's roadmap status: help wanted requesting help from the community labels Mar 9, 2022
@childish-sambino childish-sambino added the type: question question directed at the library label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix enhancement or fix that was rejected type: question question directed at the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants