Deprecate instantiating Node directly, introduce EmptyNode and Nodes #4335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
node-deprecation
branch
4 times, most recently
from
da880a9 to
20b10f3
Compare
fabpot
changed the title
stof
reviewed
Sep 26, 2024
fabpot
force-pushed
the
node-deprecation
branch
2 times, most recently
from
e1f24a9 to
e9045da
Compare
fabpot
force-pushed
the
node-deprecation
branch
from
e9045da to
8b27898
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 27, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [TwigBridge] Remove usage of `Node()` instantiations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | n/a | License | MIT See twigphp/Twig#4335 (which should be merged first) Commits ------- 29d16b0 [TwigBridge] Remove usage of Node() instantiations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some comments from @stof:
See #4292 (comment)
See #4333 (comment)
First interesting usage here: 65ee72a