[FR] dirMode and fileMode options for FilesystemCache

[brandonkelly]

Currently FilesystemCache creates directories with 777 permissions, and PHP files with 666 permissions. It would be nice if new dirMode and fileMode options were supported, which could be used to override those default permissions.

[fabpot]

I think the current code is reasonable. We're doing the same in Symfony as well. Note that the mode is affected by the umask. So, it's not necessarily 0777. You can call umask() to change the permissions.

if new dirMode and fileMode options were supported -> I'm not sure what you're referring to here?

[brandonkelly]

if new dirMode and fileMode options were supported -> I'm not sure what you're referring to here?

I was suggesting that Twig could add new dirMode and fileMode options, giving us a way to set the permissions programmatically when initializing the Twig environment.

[fabpot]

Would you agree that using umask() is enough?

[fabpot]

Any feedback on my suggestion @brandonkelly?

[ericmorand]

What about not setting any permission at all and just creating the directories and files?

[brandonkelly]

@fabpot I don’t think umask() would help in our case.

Several libraries that work with files have dirMode/dirPermission and fileMode/filePermission settings (e.g. RotatingFileHandler in Monolog), so Craft has defaultDirMode and defaultFileMode config settings, and the hope is that those could apply to directories and files created by Twig as well.

[brandonkelly]

(Sorry, didn’t mean to close the issue. Rogue trackpad click!)