Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Date picker] Pressing Escape key doesn't always close the date picker #9056

Open
Devessier opened this issue Dec 13, 2024 · 0 comments
Open
Assignees

Comments

@Devessier
Copy link
Contributor

Scope & Context

I used the InternalDatePicker component to implement the form field date input, and the Escape key doesn't work there either.

Current behavior

Pressing the Escape key only closes the date picker when the date input is focused. Otherwise, the Escape key is not caught, which causes the browser to exit fullscreen and not close the date picker.

CleanShot.2024-12-13.at.13.17.43.mp4

Expected behavior

When the date picker is opened, pressing Escape must close it in any case.

Technical inputs

We should rely on scoped hotkeys instead of adding an onKeyDown handler on the container of the packages/twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants