Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone country codes not unique #8775

Open
guillim opened this issue Nov 27, 2024 · 1 comment · May be fixed by #9035
Open

Phone country codes not unique #8775

guillim opened this issue Nov 27, 2024 · 1 comment · May be fixed by #9035
Assignees
Labels
prio: med scope: back+front Issues requiring full-stack knowledge type: chore

Comments

@guillim
Copy link
Contributor

guillim commented Nov 27, 2024

Scope & Context

We have a problem with country codes for phone numbers

Current behavior

Phone numbers: We currently store country code in the database.

{"additionalPhones":null,"primaryPhoneNumber":"''","primaryPhoneCountryCode":"'33'"}

However multiple countries share the same country code. see quora

We need to differentiate the countries, even though they sahre the same code, when displaying the country in the settings for instance

Image

Expected behavior

We should be able to see which precise country the user selected when picking a phone country

Technical inputs

  • Migration might be required so it might need to be careful

Discussed with @charlesBochet

@guillim guillim added prio: med scope: back+front Issues requiring full-stack knowledge type: chore labels Nov 27, 2024
@guillim guillim self-assigned this Dec 9, 2024
@guillim guillim moved this from 🆕 New to 🔖 Planned in Product development ✅ Dec 9, 2024
@guillim
Copy link
Contributor Author

guillim commented Dec 9, 2024

Technical input :

  • frontend : adapt the display mode of phones
  • frontend : adapt the input mode of phones
  • backend : adapt the validator of default value, and the mock files
  • backend : migrate existing primary country code & additional callingCode
  • ensure retro-compatibility with previous version (go to main branch, db:reset & upgrade-0.40:phone-calling-code-create-column, then switch to this branch )

@guillim guillim moved this from 🔖 Planned to 🏗 In Progress in Product development ✅ Dec 11, 2024
@guillim guillim linked a pull request Dec 12, 2024 that will close this issue
@guillim guillim linked a pull request Dec 12, 2024 that will close this issue
@guillim guillim changed the title Phone country codes not unique Phone country codes not unique #backend Dec 17, 2024
@guillim guillim changed the title Phone country codes not unique #backend Phone country codes not unique Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: med scope: back+front Issues requiring full-stack knowledge type: chore
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

1 participant