Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview : Inline Settings not reactive #8556

Open
5 tasks
guillim opened this issue Nov 18, 2024 · 4 comments · May be fixed by #8663
Open
5 tasks

Preview : Inline Settings not reactive #8556

guillim opened this issue Nov 18, 2024 · 4 comments · May be fixed by #8663
Assignees
@charlesBochet
Labels
-PR: wip prio: med scope: front Issues that are affecting the frontend side only

Comments

@guillim
Copy link
Contributor

guillim commented Nov 18, 2024 •
edited
Loading

Preview Form Settings are not reactive

Example:
Image

Current behavior

Go on settings and click on a Number type. You can edit the number of decimals you would like to see. However, after changing to 0 decimals we can see the preview still with on decimal.

Same behavior on changing the "Number Type" and also the settings on Text type (Wrap record on pages)

Expected behavior

The preview should be updated once the settings field is changed

Technical Suggestion

  • Numbers Settings Percentage
  • Numbers Settings Decimals
  • Text Settings
  • Date Settings
  • DateTime Settings
@guillim guillim added prio: med scope: front Issues that are affecting the frontend side only labels Nov 18, 2024
@JorgeGraciaViveros
Copy link
Contributor

Hi @guillim ! I am currently working in a group of 5 students from CMU taking an introductory software engineering course and our final project is to contribute to an open-source repo. Our project has multiple checkpoints and will be due on December 8 (meaning our PR will take longer to open). Would it be possible for us to be assigned to this issue (or any issues that you think would be a good fit)? Thanks!

@guillim
Copy link
Contributor Author

guillim commented Nov 19, 2024

Hello @JorgeGraciaViveros ,
I believe you are looking for issues that have the label "Good first issue". They are well documented and pretty easy to start with. This issue requires a bit more work IMO.
Many "Good first issue" are created every week, I am sure you will find what you want.
Thanks for your future contributions !

@guillim
Copy link
Contributor Author

guillim commented Nov 19, 2024 •
edited
Loading

Fields identified that will require changes :

  • TEXT
  • ADDRESS
  • NUMBER
  • DATE

@JorgeGraciaViveros
Copy link
Contributor

Hello @JorgeGraciaViveros , I believe you are looking for issues that have the label "Good first issue". They are well documented and pretty easy to start with. This issue requires a bit more work IMO. Many "Good first issue" are created every week, I am sure you will find what you want. Thanks for your future contributions !

That is fine by us. Would you mind assigning it so we can take a jab at it?

@guillim guillim mentioned this issue Nov 25, 2024
Closed
@guillim guillim changed the title Preview : Inline Settings not reactive Preview : Inline Settings not reactive for Numbers Nov 25, 2024
@guillim guillim changed the title Preview : Inline Settings not reactive for Numbers Preview : Inline Settings not reactive Nov 25, 2024
@guillim guillim linked a pull request Nov 25, 2024 that will close this issue
Open
@charlesBochet charlesBochet moved this from 🆕 New to 🔖 Planned in Product development ✅ Nov 25, 2024
@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In Progress in Product development ✅ Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesBochet charlesBochet

Labels
-PR: wip prio: med scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reactive form preview nklmantey/twenty
3 participants
@charlesBochet @guillim @JorgeGraciaViveros