Add cache-flush step in Twenty upgrade command #7521
Comments
|
i can work this issue |
|
/oss.gg 300 |
|
Thanks for opening an issue! It's live on oss.gg! |
|
/assign |
|
Assigned to @vamsi-duvvana! Please open a draft PR linking this issue within 48h |
|
/assign |
|
You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more. |
|
/assign |
|
Assigned to @iharsh02! Please open a draft PR linking this issue within 48h |
|
/assign @yadavshubham01 |
Flush Specific Redis Keys After Upgrade Command :---- Changes Made :---- Updated the FlushCacheCommand to allow for selective flushing of keys that match the pattern engine:*, rather than flushing the entire cache. Added a new optional parameter to specify the cache keys pattern. Ensured that the cache is flushed at the end of the upgrade command. Code Changes :---- Modified FlushCacheCommand to include a method for flushing keys by pattern. Added a new function in CacheStorageService to handle the pattern-based flushing. --------- Co-authored-by: Weiko <[email protected]>
|
/assign |
|
This issue is already assigned to another person. Please find more issues here. |
|
@vamsi-duvvana, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
@iharsh02, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
@vamsi-duvvana, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
@iharsh02, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
/unassign |
|
Issue unassigned. |
…q#7553) Flush Specific Redis Keys After Upgrade Command :---- Changes Made :---- Updated the FlushCacheCommand to allow for selective flushing of keys that match the pattern engine:*, rather than flushing the entire cache. Added a new optional parameter to specify the cache keys pattern. Ensured that the cache is flushed at the end of the upgrade command. Code Changes :---- Modified FlushCacheCommand to include a method for flushing keys by pattern. Added a new function in CacheStorageService to handle the pattern-based flushing. --------- Co-authored-by: Weiko <[email protected]>
|
@vamsi-duvvana, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
@iharsh02, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
|
/unassign |
|
This issue is not assigned to anyone. |
Scope & Context
upgrade-x.xxcommands can sometimes bring migrations to the data model and now that the default cache is redis and persistent we need to make sure to clear it by the end of the command.Current behavior
Cache needs to be flushed after we run the upgrade command
Expected behavior
Cache flush should be part of the global command
Technical inputs
A command already exists (see FlushCacheCommand) and can be directly added but it's flushing the whole cache. While this could be fine like this, I think we only want to remove keys that follow that pattern
engine:*and not interact with the rest (bull, module, ...). This command could be updated to take an optional parameter for that purpose.The text was updated successfully, but these errors were encountered: