fix: reset selected field #6040
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added functionality to reset the selected field
- Modified
onClickhandler inMenuItemto reset selection if the option matches the current value - Updated
onChangecallback to handlenullfor resetting selection
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Thanks!!! Let's hold before merging this / just want to confirm with @Bonapara this is really what we want, it feels a bit confusing to me |
|
Hi @DubemObi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6012
I worked on the select field, to enable the reset of a selected field or remove a selected option.