Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Email Sync Status Display from "Complete" to "Active" #5961

Open
Bonapara opened this issue Jun 19, 2024 · 6 comments · May be fixed by #5965
Open

Change Email Sync Status Display from "Complete" to "Active" #5961

Bonapara opened this issue Jun 19, 2024 · 6 comments · May be fixed by #5965
Assignees
@Samaresh-Das
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes

Comments

@Bonapara
Copy link
Member

Current Behavior

The chip on the Email settings displays "Complete" when emails are synced.

image

Desired Behavior

It should display "Active" to better indicate that future emails will be synced and that it is not just an import.

@bosiraphael
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Jun 19, 2024
@greptile-apps Greptile Apps
Copy link

greptile-apps bot commented Jun 19, 2024

To change the Email Sync Status display from 'Complete' to 'Active', update the label in the useGetSyncStatusOptions hook. Locate the hook in packages/twenty-front/src/modules/settings/accounts/hooks/useGetSyncStatusOptions.ts. Find the option with the value corresponding to 'Complete' and change its label to 'Active'.

References

/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsSynchronizationStatus.tsx

Ask Greptile

@Samaresh-Das
Copy link

Can I take this issue?

@akarsanth akarsanth linked a pull request Jun 19, 2024 that will close this issue
Open
@Bonapara
Copy link
Member Author

Sure @Samaresh-Das, thanks for contributing!

@charlesBochet charlesBochet mentioned this issue Jun 22, 2024
Closed
@charlesBochet
Copy link
Member

@Samaresh-Das we already have two PRs on this one. Have you started any work? If not, I'll review @akarsanth one tonight

@Samaresh-Das
Copy link

@charlesBochet Sorry I was just about to tell today, I indeed started working on it but due to some hardware problems in my laptop, it was taking time. Sure you can merge the other PRs as I cannot do much until repair. I will look forward to contributing on other issues once my laptop is fixed. Sorry for the trouble.

@charlesBochet
Copy link
Member

No worries! appreciate the interest in the project and contributing to it anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Samaresh-Das Samaresh-Das

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated MessageChannelSyncStatus enum: changed COMPLETED to ACTIVE akarsanth/twenty
3 participants
@charlesBochet @Bonapara @Samaresh-Das