Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ellipsis for long calendar event names #5267

Open
FelixMalfait opened this issue May 3, 2024 · 60 comments
Open

Missing ellipsis for long calendar event names #5267

FelixMalfait opened this issue May 3, 2024 · 60 comments
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

I just noticed we don't handle long event names properly:

Screenshot 2024-05-03 at 13 49 23
@FelixMalfait FelixMalfait added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels May 3, 2024
@orinamio
Copy link
Contributor

orinamio commented May 3, 2024

I'll look into this issue. Can you assign me to it?

@FelixMalfait
Copy link
Member Author

Sure! Thanks again @orinamio

heckop added a commit to heckop/twenty that referenced this issue May 11, 2024
@charlesBochet
Copy link
Member

I have closed #5360 today but the issue still remains!
There is a technical strategy in #5360 comments :)

@Nil2000
Copy link

Nil2000 commented Jun 24, 2024

Hi guys, I wanted to work on this and also other good-first-issues.But having problem while setting up locally. Is this the correct way I can set up locally?
I have windows installed in my PC. Instead of using wsl and all Can I not fork and clone the repo and then perform this operations?

@charlesBochet
Copy link
Member

Hi @Nil2000, these are the correct instruction, you'll indeed need WSL and a powerful enough setup on Windows to setup the project

@Nil2000
Copy link

Nil2000 commented Jun 25, 2024

Thanks @charlesBochet for the info I have set up correctly. But now I have another issue I don't see any Calender events to check this. Can you help me produce this event?
I am thinking of sending a Google Meet Request from one of my Gmail accounts to [email protected]. Do you think this will work?

@Faisal-imtiyaz123
Copy link
Contributor

@lucasbordeau Can you assign me this please.

@mittalsam98
Copy link

@Bonapara pls assign this to me, I will look into this

@lucasbordeau
Copy link
Contributor

@Faisal-imtiyaz123 Assigned

@Nabhag8848
Copy link
Contributor

Related, Same with Email, Files, Tasks, Notes.

Files
Screen.Recording.2024-08-30.at.4.52.57.PM.mov
Notes Task

@Nabhag8848
Copy link
Contributor

@FelixMalfait working on it.

@Faisal-imtiyaz123
Copy link
Contributor

@Nabhag8848 This issue is assigned to me. Kindly once check the assignee

@FelixMalfait
Copy link
Member Author

@Faisal-imtiyaz123 because it was assigned a month ago I think @Nabhag8848 assumed you weren't working on it anymore which is fair because ; see https://github.com/twentyhq/twenty/blob/main/.github/CONTRIBUTING.md#getting-started

Thanks again to both of you for your contributions! More than enough work for everyone haha :)

@Nabhag8848
Copy link
Contributor

Thanks @FelixMalfait for mentioning that !

@Faisal-imtiyaz123 you might be interested in checking out this: https://appwrite.io/blog/post/make-open-source-healthier or a even a talk by same speaker https://www.youtube.com/watch?v=YuUt5qABv_k I just went to an event yesterday which talked about what we have gone through rn :) "Contributors role on maintaining Community Health".

@Faisal-imtiyaz123
Copy link
Contributor

Faisal-imtiyaz123 commented Aug 30, 2024

@Nabhag8848 Thanks for sharing it. Will surely see it. @FelixMalfait I am sorry for taking too much time here. Actually I fell unexpectedly sick for 2+ weeks plus some other problems were there.

@Faisal-imtiyaz123 Faisal-imtiyaz123 removed their assignment Sep 4, 2024
@rajeshkrishnait
Copy link

Is this still open? Can i work on it?

@FelixMalfait
Copy link
Member Author

Probably @Nabhag8848 got stuck! So yes feel free to raise a PR! Thank you

(just make sure to look at the previously closed PR)

@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

@sonu4435
Copy link

/assign

Copy link

oss-gg bot commented Oct 21, 2024

Assigned to @sonu4435! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@sonu4435
Copy link

Hello @Bonapara ,

I've just been assigned to this issue, but I wanted to check whether it’s still open or if it has already been resolved, as there have been a lot of discussions, and the issue appears to still be open. If it's still active, could you kindly direct me to any relevant instructions or resources I need to be aware of?

Thanks in advance!

@Bonapara
Copy link
Member

Yes, still a thing @sonu4435, thanks!

CleanShot.2024-10-22.at.11.12.21.mp4

@sonu4435
Copy link

sonu4435 commented Oct 22, 2024

Hi @Bonapara ,

I’ve been assigned to this issue, and from what I’ve seen, the problem seems to be limited to the calendar section. I haven’t noticed any similar issues in other areas.

However, I don’t have a calendar currently linked to my account, and I suspect the calendar is fetched via Google OAuth. I’m receiving a 520 error, which is preventing me from logging in and seeing the calendar’s behavior. As a result, I’m unable to fully address the issue at the moment.

Could you clarify how I can find that or guide me on how to proceed? I can clone the repo and try to troubleshoot, but I might encounter the same issue unless it’s resolved first.

image

@Bonapara
Copy link
Member

Bonapara commented Oct 22, 2024

Hi @sonu4435, you can either manually add an input to the calendar object, but you'll need to create some message participants and other elements, so it's not that easy. Alternatively, you can find another Good First Issue.

If you try adding inputs to the database, you can ask for help in the #Help channel on our Discord.

Thanks for contributing!

@charlesBochet
Copy link
Member

Don't we have some calendarEvents in our dev seeds?

@charlesBochet
Copy link
Member

If not, would be great to add them!

@Bonapara
Copy link
Member

I don't think so, but we should do it when tackling #6793

Copy link

oss-gg bot commented Oct 26, 2024

@sonu4435, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 26, 2024

@sonu4435 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@oss-gg oss-gg bot unassigned sonu4435 Oct 26, 2024
@balvind3r
Copy link

/assign

Copy link

oss-gg bot commented Oct 26, 2024

Assigned to @balvind3r! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@balvind3r
Copy link

image I am having trouble keeping the frontend up...

Copy link

oss-gg bot commented Oct 28, 2024

@balvind3r, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

1 similar comment
Copy link

oss-gg bot commented Oct 30, 2024

@balvind3r, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 30, 2024

@balvind3r has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@asadath1395
Copy link

I would like to work on this one

@Bonapara
Copy link
Member

Sure @asadath1395, thanks for contributing!

@tinchil
Copy link

tinchil commented Dec 7, 2024

Hi @Bonapara , Would it be possible to assign myself to this issue? I would like to work on this task

@FelixMalfait
Copy link
Member Author

Thanks @tinchil I think there's already an ongoing PR from @asadath1395 that @bosiraphael will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
None yet
Development

Successfully merging a pull request may close this issue.