[BUGFIX] ObjectMetadata item server validation #10699
Draft
+491
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prastoin
commented
Mar 7, 2025
| @@ -67,8 +67,8 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat | |||
| ); | |||
|
|
|||
| try { | |||
| validateMetadataNameValidityOrThrow(relationMetadataInput.fromName); | |||
| validateMetadataNameValidityOrThrow(relationMetadataInput.toName); | |||
| validateObjectMetadataInputNameOrThrow(relationMetadataInput.fromName); | |||
There was a problem hiding this comment.
Review: Unless I'm mistaken we need the same strictness level here than along object model creation
prastoin
commented
Mar 7, 2025
| @@ -199,7 +215,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt | |||
| input: UpdateOneObjectInput, | |||
| workspaceId: string, | |||
| ): Promise<ObjectMetadataEntity> { | |||
| validateObjectMetadataInputOrThrow(input.update); | |||
| validateObjectMetadataInputNamesOrThrow(input.update); | |||
There was a problem hiding this comment.
Note: Will pass on update in an other PR
prastoin
force-pushed
the
prastoin-bugfix-names-object-model-empty-string
branch
from
0a59f34 to
6a33e9b
Compare
prastoin
force-pushed
the
prastoin-bugfix-names-object-model-empty-string
branch
2 times, most recently
from
8a2f744 to
cdccc57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR contains several SNAPSHOT files explaining big +
While refactoring the Object Model settings page in #10653, encountered a critical issue when submitting either one or both names with
""empty string hard corrupting a workspace.This motivate this PR reviewing server side validation
I feel like we could shared zod schema between front and back
Refactored server validation
What to expect from Names:
What to expect from Labels:
close #10694
Creation integrations tests
Created new integrations tests, following EachTesting pattern and uses snapshot to assert errors message. These tests cover several failing use cases and started to implement ones for the happy path but object metadata item deletion is currently broken unless I'm mistaken @Weiko is on it
Notes