From 59eb10ccc474c85c5f513f3e7b83aa6844407e12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustavo=20F=C3=A9lix?= <gu2003fr@outlook.com>
Date: Tue, 25 Jul 2023 15:21:45 -0300
Subject: [PATCH] =?UTF-8?q?fix(#753):=20add=20autoComplete=20attribute=20f?=
 =?UTF-8?q?or=20remove=20suggestion=20of=20passwo=E2=80=A6=20(#913)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix(#753): add autoComplete attribute for remove suggestion of password managers

* fix(#753): add autoComplete attribute for remove suggestion of password managers

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
---
 .../activities/right-drawer/components/CommentThread.tsx        | 1 +
 .../board/card-field/components/BoardCardEditableFieldText.tsx  | 1 +
 .../modules/ui/board/components/BoardColumnEditTitleMenu.tsx    | 1 +
 front/src/modules/ui/dropdown/components/DropdownMenuSearch.tsx | 1 +
 .../ui/inplace-input/components/InplaceInputDoubleText.tsx      | 1 +
 .../modules/ui/inplace-input/components/InplaceInputText.tsx    | 1 +
 front/src/modules/ui/input/components/Checkbox.tsx              | 1 +
 front/src/modules/ui/input/components/TextInput.tsx             | 1 +
 .../editable-cell/types/EditableCellDoubleTextEditMode.tsx      | 2 ++
 .../modules/ui/table/editable-cell/types/EditableCellPhone.tsx  | 1 +
 .../modules/ui/table/editable-cell/types/EditableCellText.tsx   | 1 +
 .../modules/ui/table/editable-cell/types/EditableCellURL.tsx    | 1 +
 front/src/modules/ui/table/editable-cell/types/EditableChip.tsx | 1 +
 13 files changed, 14 insertions(+)

diff --git a/front/src/modules/activities/right-drawer/components/CommentThread.tsx b/front/src/modules/activities/right-drawer/components/CommentThread.tsx
index 97da2120061a..e37706dbaeef 100644
--- a/front/src/modules/activities/right-drawer/components/CommentThread.tsx
+++ b/front/src/modules/activities/right-drawer/components/CommentThread.tsx
@@ -159,6 +159,7 @@ export function CommentThread({
             <CommentThreadActionBar commentThreadId={commentThread?.id ?? ''} />
           </StyledTopActionsContainer>
           <StyledEditableTitleInput
+            autoComplete="off"
             autoFocus
             placeholder={`${commentThread.type} title (optional)`}
             onChange={(event) => {
diff --git a/front/src/modules/ui/board/card-field/components/BoardCardEditableFieldText.tsx b/front/src/modules/ui/board/card-field/components/BoardCardEditableFieldText.tsx
index 11e37b1e91a2..8e612c2c679b 100644
--- a/front/src/modules/ui/board/card-field/components/BoardCardEditableFieldText.tsx
+++ b/front/src/modules/ui/board/card-field/components/BoardCardEditableFieldText.tsx
@@ -33,6 +33,7 @@ export function BoardCardEditableFieldText({
           placeholder={placeholder || ''}
           autoFocus
           value={internalValue}
+          autoComplete="off"
           onChange={(event: ChangeEvent<HTMLInputElement>) => {
             setInternalValue(event.target.value);
             debouncedOnChange(event.target.value);
diff --git a/front/src/modules/ui/board/components/BoardColumnEditTitleMenu.tsx b/front/src/modules/ui/board/components/BoardColumnEditTitleMenu.tsx
index e23e9a39e625..fb19966b8789 100644
--- a/front/src/modules/ui/board/components/BoardColumnEditTitleMenu.tsx
+++ b/front/src/modules/ui/board/components/BoardColumnEditTitleMenu.tsx
@@ -77,6 +77,7 @@ export function BoardColumnEditTitleMenu({
         <StyledEditModeInput
           value={internalValue}
           onChange={handleChange}
+          autoComplete="off"
           autoFocus
         />
       </StyledEditTitleContainer>
diff --git a/front/src/modules/ui/dropdown/components/DropdownMenuSearch.tsx b/front/src/modules/ui/dropdown/components/DropdownMenuSearch.tsx
index 3f5f5be52344..19839be62d44 100644
--- a/front/src/modules/ui/dropdown/components/DropdownMenuSearch.tsx
+++ b/front/src/modules/ui/dropdown/components/DropdownMenuSearch.tsx
@@ -30,6 +30,7 @@ export function DropdownMenuSearch(
   return (
     <DropdownMenuSearchContainer>
       <StyledEditModeSearchInput
+        autoComplete="off"
         {...props}
         placeholder={props.placeholder ?? 'Search'}
       />
diff --git a/front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx b/front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx
index aabdbf770b0d..fb042284afce 100644
--- a/front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx
+++ b/front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx
@@ -40,6 +40,7 @@ export function InplaceInputDoubleText({
         }}
       />
       <StyledInput
+        autoComplete="off"
         placeholder={secondValuePlaceholder}
         value={secondValue}
         onChange={(event: ChangeEvent<HTMLInputElement>) => {
diff --git a/front/src/modules/ui/inplace-input/components/InplaceInputText.tsx b/front/src/modules/ui/inplace-input/components/InplaceInputText.tsx
index 5c84c64a4bef..ac086b4ece8f 100644
--- a/front/src/modules/ui/inplace-input/components/InplaceInputText.tsx
+++ b/front/src/modules/ui/inplace-input/components/InplaceInputText.tsx
@@ -26,6 +26,7 @@ export function InplaceInputText({
   return (
     <InplaceInputContainer>
       <InplaceInputTextInput
+        autoComplete="off"
         autoFocus={autoFocus}
         placeholder={placeholder}
         value={value}
diff --git a/front/src/modules/ui/input/components/Checkbox.tsx b/front/src/modules/ui/input/components/Checkbox.tsx
index a79cf9e4c86d..b07bfc444783 100644
--- a/front/src/modules/ui/input/components/Checkbox.tsx
+++ b/front/src/modules/ui/input/components/Checkbox.tsx
@@ -94,6 +94,7 @@ export function Checkbox({
   return (
     <StyledInputContainer>
       <StyledInput
+        autoComplete="off"
         type="checkbox"
         name="styled-checkbox"
         data-testid="input-checkbox"
diff --git a/front/src/modules/ui/input/components/TextInput.tsx b/front/src/modules/ui/input/components/TextInput.tsx
index c50a7d1dd583..b4ff6bffa096 100644
--- a/front/src/modules/ui/input/components/TextInput.tsx
+++ b/front/src/modules/ui/input/components/TextInput.tsx
@@ -150,6 +150,7 @@ export function TextInput({
       {label && <StyledLabel>{label + (required ? '*' : '')}</StyledLabel>}
       <StyledInputContainer>
         <StyledInput
+          autoComplete="off"
           ref={inputRef}
           tabIndex={props.tabIndex ?? 0}
           onFocus={handleFocus}
diff --git a/front/src/modules/ui/table/editable-cell/types/EditableCellDoubleTextEditMode.tsx b/front/src/modules/ui/table/editable-cell/types/EditableCellDoubleTextEditMode.tsx
index a5f969b44c69..f2b24af1fba1 100644
--- a/front/src/modules/ui/table/editable-cell/types/EditableCellDoubleTextEditMode.tsx
+++ b/front/src/modules/ui/table/editable-cell/types/EditableCellDoubleTextEditMode.tsx
@@ -138,6 +138,7 @@ export function EditableCellDoubleTextEditMode({
   return (
     <StyledContainer ref={wrapperRef}>
       <StyledInput
+        autoComplete="off"
         autoFocus
         placeholder={firstValuePlaceholder}
         ref={firstValueInputRef}
@@ -147,6 +148,7 @@ export function EditableCellDoubleTextEditMode({
         }}
       />
       <StyledInput
+        autoComplete="off"
         placeholder={secondValuePlaceholder}
         ref={secondValueInputRef}
         value={secondValue}
diff --git a/front/src/modules/ui/table/editable-cell/types/EditableCellPhone.tsx b/front/src/modules/ui/table/editable-cell/types/EditableCellPhone.tsx
index 2f97b8962d67..e777145a11df 100644
--- a/front/src/modules/ui/table/editable-cell/types/EditableCellPhone.tsx
+++ b/front/src/modules/ui/table/editable-cell/types/EditableCellPhone.tsx
@@ -14,6 +14,7 @@ export function EditableCellPhone({ value, placeholder, onSubmit }: OwnProps) {
     <EditableCell
       editModeContent={
         <InplaceInputTextEditMode
+          autoComplete="off"
           autoFocus
           placeholder={placeholder || ''}
           value={value}
diff --git a/front/src/modules/ui/table/editable-cell/types/EditableCellText.tsx b/front/src/modules/ui/table/editable-cell/types/EditableCellText.tsx
index d20f20137df5..798e67fea31e 100644
--- a/front/src/modules/ui/table/editable-cell/types/EditableCellText.tsx
+++ b/front/src/modules/ui/table/editable-cell/types/EditableCellText.tsx
@@ -32,6 +32,7 @@ export function EditableCellText({
           autoFocus
           value={value}
           onSubmit={(newText) => onSubmit?.(newText)}
+          autoComplete="off"
         />
       }
       nonEditModeContent={
diff --git a/front/src/modules/ui/table/editable-cell/types/EditableCellURL.tsx b/front/src/modules/ui/table/editable-cell/types/EditableCellURL.tsx
index 56babdc2042d..d5b3b6ac3db9 100644
--- a/front/src/modules/ui/table/editable-cell/types/EditableCellURL.tsx
+++ b/front/src/modules/ui/table/editable-cell/types/EditableCellURL.tsx
@@ -27,6 +27,7 @@ export function EditableCellURL({
       editModeContent={
         <InplaceInputTextEditMode
           placeholder={placeholder}
+          autoComplete="off"
           autoFocus
           value={url}
           onSubmit={(newURL) => onSubmit?.(newURL)}
diff --git a/front/src/modules/ui/table/editable-cell/types/EditableChip.tsx b/front/src/modules/ui/table/editable-cell/types/EditableChip.tsx
index 62e4816c806a..8a66ea003c18 100644
--- a/front/src/modules/ui/table/editable-cell/types/EditableChip.tsx
+++ b/front/src/modules/ui/table/editable-cell/types/EditableChip.tsx
@@ -56,6 +56,7 @@ export function EditableCellChip({
           placeholder={placeholder || ''}
           autoFocus
           value={inputValue}
+          autoComplete="off"
           onSubmit={(newValue) => onSubmit?.(newValue)}
         />
       }