Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail gracefully on populating RegisterData and MemoryRegions from iterators #33

Open
hdoordt opened this issue Aug 23, 2023 · 0 comments
Open

Fail gracefully on populating RegisterData and MemoryRegions from iterators #33

hdoordt opened this issue Aug 23, 2023 · 0 comments

Comments

@hdoordt
Copy link

hdoordt commented Aug 23, 2023 •
edited
Loading

Currently, RegisterData and MemoryRegion panic in their FromIterator::from_iter implementations if:

  • the first item does not match the expected identifier
  • the iterator does not contain enough items

This is undesirable when handling possibly corrupted data. I propose adding a non-panicking way to build RegisterData and MemoryRegion objects from byte iterators
@hdoordt hdoordt changed the title Fai Fail gracefully on populating RegisterData and MemoryRegions from iterators Aug 23, 2023
@hdoordt hdoordt mentioned this issue Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hdoordt