Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johan theme 'Restart Story' link fails #8

Open
taskboy3000 opened this issue Feb 20, 2013 · 2 comments
Open

Johan theme 'Restart Story' link fails #8

taskboy3000 opened this issue Feb 20, 2013 · 2 comments

Comments

@taskboy3000
Copy link

The 'Restart Story' link (upper right corner) appears to fail when clicked. It is link to this:

Restart Story

In the sugarcane header.html, there is a Interface object with a similar method. This object does not appear to be present in jonah.

However, the tooltip "rewind to here" does work.

@taskboy3000
Copy link
Author

The method definition of History.restart I think should be changed to
History.prototype.restart=function(){window.location=""}

This removes window.location.hash, which I think attempts to preserve JSON state. This is unneeded here since the user wants to restart state entirely. I might even recommend a full page refresh to clear out the DOM.

window.location.reload();

@HarmlessTrouble
Copy link
Member

Restart Story Functions as expected (displaying the Start Passage) when there is no hash or hashbang in the url.
When a passage id or passage title is present in the url the story restarts to the last passage id in the hash or to the hashbang title.
This is nice if you want to restart from your last bookmark. But I agree it's not what you expect from a "Restart story" link. And as you mentioned the user has a"rewind to here" link.

thedeadparrot pushed a commit to thedeadparrot/twee that referenced this issue Sep 20, 2014
Updated the test play/start at passage feature to be header agnostic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants