Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional encodings (or even hashes?) for indicator matching #14

Open
baltpeter opened this issue May 25, 2023 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@baltpeter
Copy link
Member

baltpeter commented May 25, 2023

In #6, I'm implementing basic indicator matching with support for plain text, base64, and URL encoded text.

But with the framework we have, there's really no reason not to go beyond that. A few ideas for additional encodings we could support:

  • hex
  • HTML entities
  • Unicode escaping
  • quoted printable
  • punycode

In addition, we could even compute common hashes of the indicators and check for those.

@baltpeter baltpeter added the enhancement New feature or request label May 25, 2023
@baltpeter
Copy link
Member Author

For the hashes, in line with the existing hashedIdfa property, we should probably prepend hashed to the property name the user set.

@baltpeter baltpeter added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant