You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, our PrettyCooked features suffers from small inaccuracies:
module Pretty.Cooked is far too long
we sometimes use PP.pretty instead of prettyCookedOpts
some PrettyCooked instances are located in Pretty.Class, some others in Pretty.Cooked and the reason for this separation is unclear.
some PrettyCooked instances are actually written as instances, while others are functions named prettyXXX but are basically instances. This can lead to repeated code if one does not realize an instance is here but is not actually written as such.
PrettyCooked has it own hashable type class which could maybe be factored with toScriptHash to some extent (see Homogenize Hashing #424)
In addition, there could be some improvements:
code can be factored (for example for redeemers)
we could provide some automation to deduce PrettyCooked instances
The text was updated successfully, but these errors were encountered:
what was the thought process behind centralizing all pretty cooked instances in dedicated modules? I find it very prone to circular dependencies issues.
At the moment, our
PrettyCooked
features suffers from small inaccuracies:Pretty.Cooked
is far too longPP.pretty
instead ofprettyCookedOpts
PrettyCooked
instances are located inPretty.Class
, some others inPretty.Cooked
and the reason for this separation is unclear.PrettyCooked
instances are actually written as instances, while others are functions namedprettyXXX
but are basically instances. This can lead to repeated code if one does not realize an instance is here but is not actually written as such.PrettyCooked
has it ownhashable
type class which could maybe be factored withtoScriptHash
to some extent (see Homogenize Hashing #424)In addition, there could be some improvements:
The text was updated successfully, but these errors were encountered: