- Allow to make thread dump directly from the application.

- CSS improvements
- Refactoring

Author: twasyl

README.md

@@ -11,10 +11,10 @@ JStackFX requires the latest JDK 8 available on your system.
 
 # Build
 
-As JStackFX is currently under development, you have to build it manually in order to use it. In order to build it, ensure the JDK 8 is available and execute the following command:
+As JStackFX is currently under development, you can build it manually in order to have the latest version. In order to build it, ensure the JDK 8 is available and execute the following command:
 
 ```shell
-gradlew clean distZip
+gradlew clean assemble
 ```
 
 # Execution
@@ -31,6 +31,14 @@ In order to start JStackFX and open directly a dump file you can use the followi
 java -jar jstackfx-<version>.jar --file=/path/to/dump.txt
 ```
 
+In order to start JStackFX and make a thread dump of a given process you can use the following command:
+
+```shell
+java -jar jstackfx-<version>.jar --pid=<pid of the process to dump>
+```
+
+**Warning:** if both `--pid` and `--file` parameters are used, `--file` is ignored.
+
 # Screenshot
 
 ![Screenshot of JStackFX](src/site/screenshots/JStackFX_01.png)

src/main/java/io/twasyl/jstackfx/JStackFX.java

@@ -7,27 +7,31 @@
 import javafx.scene.Scene;
 import javafx.scene.control.Alert;
 import javafx.scene.control.ButtonType;
-import javafx.scene.control.Dialog;
 import javafx.stage.Stage;
 
 import java.io.File;
-import java.io.IOException;
 import java.util.Map;
 
 /**
+ * Application class of JStackFX.
+ *
  * @author Thierry Wasylczenko
- * @since jStackFX @@NEXT-VERSION@@
+ * @since JStackFX 1.0
  */
 public class JStackFX extends Application {
     protected static final String FILE_PARAMETER = "file";
+    protected static final String PID_PARAMETER = "pid";
 
     private File fileToOpenAtStartup = null;
+    private String pidToDumpAtStartup = null;
 
     @Override
     public void init() throws Exception {
         final Map<String, String> parameters = getParameters().getNamed();
 
-        if (parameters.containsKey(FILE_PARAMETER)) {
+        if(parameters.containsKey(PID_PARAMETER)) {
+            this.pidToDumpAtStartup = parameters.get(PID_PARAMETER);
+        } else if (parameters.containsKey(FILE_PARAMETER)) {
             this.fileToOpenAtStartup = new File(parameters.get(FILE_PARAMETER));
         }
     }
@@ -37,7 +41,17 @@ public void start(Stage stage) throws Exception {
         final FXMLLoader loader = new FXMLLoader(JStackFX.class.getResource("/io/twasyl/jstackfx/fxml/jstackfx.fxml"));
         final Parent root = loader.load();
 
-        if (this.fileToOpenAtStartup != null) {
+        if(this.pidToDumpAtStartup != null) {
+            final JStackFXController controller = loader.getController();
+            try {
+                final long pid = Long.parseLong(this.pidToDumpAtStartup);
+                controller.dumpPID(pid);
+            } catch (Exception e) {
+                final Alert errorDialog = new Alert(Alert.AlertType.ERROR, e.getMessage(), ButtonType.OK);
+                errorDialog.setTitle("Can create thread dump for process " + this.pidToDumpAtStartup);
+                errorDialog.showAndWait();
+            }
+        } else if (this.fileToOpenAtStartup != null) {
             final JStackFXController controller = loader.getController();
             try {
                 controller.loadDumpFile(this.fileToOpenAtStartup);
@@ -52,7 +66,7 @@ public void start(Stage stage) throws Exception {
 
         stage.setScene(scene);
         stage.setTitle("JStackFX");
-//        stage.setMaximized(true);
+        stage.setMaximized(true);
         stage.show();
     }
 

src/main/java/io/twasyl/jstackfx/beans/Dump.java

@@ -8,17 +8,22 @@
 import javafx.scene.text.Text;
 
 import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;
 import java.util.List;
 
 /**
+ * Class representing a thread dump realized with the {@code jstack} tool.
+ *
  * @author Thierry Wasylczenko
- * @since jStackFX @@NEXT-VERSION@@
+ * @since JStackFX 1.0
  */
-public class Dump {
+public abstract class Dump {
+    protected static final DateTimeFormatter DATE_TIME_FORMATTER_OUTPUT = DateTimeFormatter.ofPattern("uuuu-MM-dd HH:mm:ss");
+
     protected final ObjectProperty<LocalDateTime> generationDateTime = new SimpleObjectProperty<>();
     protected final StringProperty description = new SimpleStringProperty();
-    protected final ListProperty<ThreadInformation> elements = new SimpleListProperty<>(FXCollections.observableArrayList());
+    protected final ListProperty<ThreadElement> elements = new SimpleListProperty<>(FXCollections.observableArrayList());
     protected final IntegerProperty numberOfJNIRefs = new SimpleIntegerProperty(0);
 
     public ObjectProperty<LocalDateTime> generationDateTimeProperty() { return generationDateTime; }
@@ -29,9 +34,9 @@ public class Dump {
     public String getDescription() { return description.get(); }
     public void setDescription(String description) { this.description.set(description); }
 
-    public ListProperty<ThreadInformation> elementsProperty() { return elements; }
-    public ObservableList<ThreadInformation> getElements() { return elements.get(); }
-    public void setElements(ObservableList<ThreadInformation> elements) { this.elements.set(elements); }
+    public ListProperty<ThreadElement> elementsProperty() { return elements; }
+    public ObservableList<ThreadElement> getElements() { return elements.get(); }
+    public void setElements(ObservableList<ThreadElement> elements) { this.elements.set(elements); }
 
     public IntegerProperty numberOfJNIRefsProperty() { return numberOfJNIRefs; }
     public int getNumberOfJNIRefs() { return numberOfJNIRefs.get(); }
@@ -66,7 +71,7 @@ public List<Text> asText() {
         final Font normal = Font.font("Helvetica", FontWeight.NORMAL, 12);
         final Font code = Font.font("Courier New", FontWeight.NORMAL, 12);
 
-        Text text = new Text("Generated at " + this.getGenerationDateTime().toString());
+        Text text = new Text("Generated at " + DATE_TIME_FORMATTER_OUTPUT.format(this.getGenerationDateTime()));
         text.setFont(bold);
         texts.add(text);
 

src/main/java/io/twasyl/jstackfx/beans/FileDump.java

@@ -0,0 +1,20 @@
+package io.twasyl.jstackfx.beans;
+
+import javafx.beans.property.ObjectProperty;
+import javafx.beans.property.SimpleObjectProperty;
+
+import java.io.File;
+
+/**
+ * An implementation of {@link Dump} for thread dumps stored within files.
+ *
+ * @author Thierry Wasylczenko
+ * @since JStackFX 1.0
+ */
+public class FileDump extends Dump {
+    private ObjectProperty<File> file = new SimpleObjectProperty<>();
+
+    public ObjectProperty<File> fileProperty() { return file; }
+    public File getFile() { return file.get(); }
+    public void setFile(File file) { this.file.set(file); }
+}

src/main/java/io/twasyl/jstackfx/beans/InMemoryDump.java

@@ -0,0 +1,21 @@
+package io.twasyl.jstackfx.beans;
+
+import javafx.beans.property.ListProperty;
+import javafx.beans.property.SimpleListProperty;
+import javafx.collections.FXCollections;
+import javafx.collections.ObservableList;
+
+/**
+ * An implementation of {@link Dump} for thread dumps realized in memory and which results haven't been stored within
+ * a file.
+ *
+ * @author Thierry Wasylczenko
+ * @since JStackFX 1.0
+ */
+public class InMemoryDump extends Dump {
+    private final ListProperty<String> lines = new SimpleListProperty<>(FXCollections.observableArrayList());
+
+    public ListProperty<String> linesProperty() { return lines; }
+    public ObservableList<String> getLines() { return lines.get(); }
+    public void setLines(ObservableList<String> lines) { this.lines.set(lines); }
+}

src/main/java/io/twasyl/jstackfx/beans/Pair.java

@@ -1,8 +1,10 @@
 package io.twasyl.jstackfx.beans;
 
 /**
+ * Simple class for associating two objects.
+ *
  * @author Thierry Wasylczenko
- * @since jStackFX @@NEXT-VERSION@@
+ * @since JStackFX 1.0
  */
 public class Pair<K, V> {
     protected K value1;