Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping "Show More" in Notifications expands >1 CW'd toot #4928

Open
ieure opened this issue Feb 20, 2025 · 3 comments
Open

Tapping "Show More" in Notifications expands >1 CW'd toot #4928

ieure opened this issue Feb 20, 2025 · 3 comments
Labels

Comments

@ieure
Copy link

ieure commented Feb 20, 2025

Detailed description

If two people boost or fav a CW'd toot, each action is shown individually in the Notifications tab. Tapping the "Show More" button to expand the toot contents expands it for every instance of the toot in Notifications, which feels weird and wrong.

Steps to reproduce the problem

  1. Toot something good enough for at least two people to fav and/or boost.
  2. Switch to your Notifications tab, see the toot twice.
  3. Tap "Show More" on either toot.
  4. Observe that the other copies of the same toot also expand, even though you did not tap them.

Screen recording of this:

screen-20250219-203921.mp4

Debug information

Tusky 27.2
Google Pixel 8
Android version: 15
SDK version: 35

@ieure ieure added the bug label Feb 20, 2025
@connyduck
Copy link
Collaborator

That is a sideeffect of synchronising all posts (so you favorite it in one place it is favorited everywhere etc). Not sure how this can be fixed because not synchronizing or storing each post multiple times are also not really good options.

@abackstrom
Copy link

My personal opinion is that expanding all the posts is fine, but shifting the tapped post's position in the viewport is jarring. Is it possible to keep the tapped post in the same place and shift the other posts around it?

@ieure
Copy link
Author

ieure commented Feb 28, 2025

My personal opinion is that expanding all the posts is fine, but shifting the tapped post's position in the viewport is jarring. Is it possible to keep the tapped post in the same place and shift the other posts around it?

That's certainly a part of it, but it is never going to feel right to tap one thing and have a different thing react to it.

I think the best solution would be to show the toot once with an "N people [faved and/or boosted] this," which you could tap to see who did what when. Is something like that in the works? TweetBot did that, back when I used Twitter, and I thought it was a good feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants